Refactor Azure Clients #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marwanad
commented
Oct 30, 2018
marwanad
commented
Oct 30, 2018
| @@ -151,19 +136,6 @@ func (azure *AzureClient) Create(cluster *clusterv1.Cluster, machine *clusterv1. | |||
| // Update an existing machine based on the cluster and machine spec passed. | |||
| // Currently only checks machine existence and does not update anything. | |||
| func (azure *AzureClient) Update(cluster *clusterv1.Cluster, goalMachine *clusterv1.Machine) error { | |||
marwanad
commented
Oct 30, 2018
| @@ -15,80 +15,118 @@ package machine | |||
| import ( | |||
There was a problem hiding this comment.
test coverage for the actuator is around: 53% - I'll add more unit tests to increase coverage
marwanad
force-pushed
the
refactor-azure-clients
branch
from
7257702 to
76be01c
Compare
|
@vannrt done the rebase |
easier to filter azure resources tied to a machine
vannrt
approved these changes
Nov 5, 2018
marwanad
added a commit
to marwanad/cluster-api-provider-azure
that referenced
this pull request
Nov 6, 2018
* add interfaces for deployment operations * implement deployments azure client * replace machine create with the new azure clients * remove machine update placeholder * replace exists with the new clients * remove unused methods in the machine actuator * add getting public ip address to the networks interface * cleanup machine actuator * remove unused params and methods in the actuators * remove old clients tests * update machine actuator tests * remove wrappers package * tag created resources by machine name easier to filter azure resources tied to a machine * fix typo * re-add GetIP method * move loading the environment variables to the actuator manager
6 tasks
luthermonson
pushed a commit
to luthermonson/cluster-api-provider-azure
that referenced
this pull request
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20.